feat: add guardrails for headed mode #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrandiaz
reviewed
Jan 21, 2026
| } | ||
| } | ||
| } catch { | ||
| // Config loading errors are handled by existing playwrightConfigPath validation |
Contributor
There was a problem hiding this comment.
Can you verify this? I don't think this is 100% true, if we fail to load we should throw an error that we are unable to parse the config
Member
Author
There was a problem hiding this comment.
@ferrandiaz Thanks for the review, you are right. Should be fixed now.
ferrandiaz
previously approved these changes
Jan 21, 2026
sorccu
requested changes
Jan 21, 2026
sorccu
reviewed
Jan 28, 2026
| const playwrightConfig = await Session.loadFile<any>(this.playwrightConfigPath) | ||
|
|
||
| if (playwrightConfig?.use?.headless === false) { | ||
| diagnostics.add(new UnsupportedPropertyDiagnostic( |
Member
There was a problem hiding this comment.
If only false is not supported, use InvalidPropertyValueDiagnostic. If any value is unsupported, then use UnsupportedPropertyDiagnostic. It will slightly change the error message, so adjust tests accordingly if needed.
Member
Author
There was a problem hiding this comment.
@sorccu You are correct, the property is supported with value: true. Changing it to InvalidPropertyValueDiagnostic.
sorccu
reviewed
Jan 28, 2026
sorccu
approved these changes
Jan 28, 2026
sorccu
deleted the
pilar/tra-1789-add-cli-guardrails-to-common-errors-webserver-headed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
Detect if theres a headless: false in the playwright.config and show an error.